[webkit-reviews] review granted: [Bug 199456] Use smarter pointers in WKDownloadProgress : [Attachment 373397] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 3 13:14:49 PDT 2019


Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 199456: Use smarter pointers in WKDownloadProgress
https://bugs.webkit.org/show_bug.cgi?id=199456

Attachment 373397: Patch

https://bugs.webkit.org/attachment.cgi?id=373397&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 373397
  --> https://bugs.webkit.org/attachment.cgi?id=373397
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373397&action=review

> Source/WebKit/NetworkProcess/Downloads/cocoa/WKDownloadProgress.mm:76
> +	   if (!isMainThread()) {

!RunLoop::isMain() to avoid issues when the app uses both WK1 and WK2.


More information about the webkit-reviews mailing list