[webkit-reviews] review granted: [Bug 199430] REGRESSION (iOS 13): Tapping an element with a click event handler no longer clears the selection : [Attachment 373390] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 199430: REGRESSION (iOS 13): Tapping an element with a click event handler
no longer clears the selection
https://bugs.webkit.org/show_bug.cgi?id=199430

Attachment 373390: Patch

https://bugs.webkit.org/attachment.cgi?id=373390&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 373390
  --> https://bugs.webkit.org/attachment.cgi?id=373390
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373390&action=review

> Source/WebCore/ChangeLog:8
> +	   After <trac.webkit.org/r245067>, we no longer immediately clear the
text selection when recognizing a single tap

Whoops

> Source/WebCore/ChangeLog:24
> +	   breaking the fix in r233311 by matching macOS behavior and not
bailing via early return in the case where the

Very nice!