[webkit-reviews] review requested: [Bug 199257] [iOS] Support select all in non-editable element : [Attachment 373370] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 199257: [iOS] Support select all in non-editable element
https://bugs.webkit.org/show_bug.cgi?id=199257

Attachment 373370: Patch

https://bugs.webkit.org/attachment.cgi?id=373370&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Created attachment 373370

  --> https://bugs.webkit.org/attachment.cgi?id=373370&action=review

Patch

I need to check if this is okay to do in iOS 12. At least iBooks on iOS 12
allows select all of non-editable content...need to confirm if this was
platform convention and WebKit was being too restrictive. Otherwise, will need
to keep existing select all condition for iOS 12 and compile-time switch to
return YES otherwise. Thoughts?