[webkit-reviews] review granted: [Bug 199408] [ews-build] Add build steps to Install Wpe and Gtk dependencies : [Attachment 373334] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 199408: [ews-build] Add build steps to Install Wpe and Gtk dependencies
https://bugs.webkit.org/show_bug.cgi?id=199408

Attachment 373334: Patch

https://bugs.webkit.org/attachment.cgi?id=373334&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 373334
  --> https://bugs.webkit.org/attachment.cgi?id=373334
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373334&action=review

So I don't see how these new classes get used anywhere? Is it magic? :D

>> Tools/BuildSlaveSupport/ews-build/steps.py:597
>> +	name = 'jhbuild'
> 
> Not sure why this step is called 'jhbuild'. Copied it from build.webkit.org
configuration.

JHBuild is a development build environment that everything runs in. Basically
it's an overlay on top of the host's system dependencies where we can build and
install software to be used inside the JHBuild environment without requiring
root.

We usually write "jhbuild" because the Shift key requires effort to press. :)

> Tools/BuildSlaveSupport/ews-build/steps.py:601
> +    haltOnFailure = False

Hm, I think failure should be fatal. We have a big problem if the JHBuild step
fails. It's unlikely WebKit would actually be able to run successfully in this
case anyway.