[webkit-reviews] review granted: [Bug 199416] [WPE][GTK] Remove flatpak sandbox : [Attachment 373351] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Patrick Griffis
<pgriffis at igalia.com>'s request for review:
Bug 199416: [WPE][GTK] Remove flatpak sandbox
https://bugs.webkit.org/show_bug.cgi?id=199416

Attachment 373351: Patch

https://bugs.webkit.org/attachment.cgi?id=373351&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 373351
  --> https://bugs.webkit.org/attachment.cgi?id=373351
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373351&action=review

> Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:130
> -    if (sandboxEnabled && isInsideFlatpak())
> -	   process = flatpakSpawn(launcher.get(), m_launchOptions, argv,
socketPair.client, &error.outPtr());
> -#if ENABLE(BUBBLEWRAP_SANDBOX)
> -    else if (sandboxEnabled)
> +    if (sandboxEnabled)
>	   process = bubblewrapSpawn(launcher.get(), m_launchOptions, argv,
&error.outPtr());
> -#endif
>      else
>  #endif

Don't we still need the isInsideFlatpak() check? Surely bubblewrap isn't going
to work inside flatpak?