[webkit-reviews] review granted: [Bug 193841] REGRESSION (r238563): Web Inspector: Selection is erratic when holding Up/Down on Network Table : [Attachment 373292] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 193841: REGRESSION (r238563): Web Inspector: Selection is erratic when
holding Up/Down on Network Table
https://bugs.webkit.org/show_bug.cgi?id=193841

Attachment 373292: Patch

https://bugs.webkit.org/attachment.cgi?id=373292&action=review




--- Comment #15 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 373292
  --> https://bugs.webkit.org/attachment.cgi?id=373292
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373292&action=review

r=me, with one issue/fix inside `revealRow`.  Please address before landing.

> Source/WebInspectorUI/ChangeLog:9
> +	   Selecting and revealing a row after reload Table data, but before
the

"after reloading Table data"

> Source/WebInspectorUI/UserInterface/Views/Table.js:-369
> -	   // Force our own scroll update because we may have scrolled.
> -	   this._cachedScrollTop = NaN;

Why was this removed?  In the `_isRowVisible` path, we'd still want to reset
the `_cachedScrollTop` after calling `scrollIntoViewIfNeeded`.

> Source/WebInspectorUI/UserInterface/Views/Table.js:1457
> +    _ensureOffsetHeight()

NICE!  This is awesome.  I think I may have been a bit "overzealous" with the
name though, as "ensure" is a bit weird.  Perhaps we could settle on
`_calculateOffsetHeight`?