[webkit-reviews] review granted: [Bug 198719] Web Inspector: Audit: missing demo audits for WebInspectorAudit functions : [Attachment 371748] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 198719: Web Inspector: Audit: missing demo audits for WebInspectorAudit
functions
https://bugs.webkit.org/show_bug.cgi?id=198719

Attachment 371748: Patch

https://bugs.webkit.org/attachment.cgi?id=371748&action=review




--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 371748
  --> https://bugs.webkit.org/attachment.cgi?id=371748
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371748&action=review

r=me

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:1082
> +localizedStrings["These tests are examples of how to use %s to access
information not normally available via JavaScript."] = "These tests are
examples of how to use %s to access information not normally available via
JavaScript.";

"via JavaScript" -> "to JavaScript"

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:1083
> +localizedStrings["These tests are examples of how to use %s to get more
information about DOM nodes."] = "These tests are examples of how to use %s to
get more information about DOM nodes.";

Why is the "more" necessary? What does it convey? Can it just be "get
information about"?

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:1085
> +localizedStrings["These tests are examples of how to use %s to get more
information about the accessibility tree."] = "These tests are examples of how
to use %s to get more information about the accessibility tree.";

For all of these, I'd change "These tests are examples of how to" to "These
tests demonstrate how to".