[webkit-reviews] review granted: [Bug 199199] [FTW] Build WebCore : [Attachment 373163] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 199199: [FTW] Build WebCore
https://bugs.webkit.org/show_bug.cgi?id=199199

Attachment 373163: Patch

https://bugs.webkit.org/attachment.cgi?id=373163&action=review




--- Comment #18 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 373163
  --> https://bugs.webkit.org/attachment.cgi?id=373163
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373163&action=review

r=me with AppleWin building.

I do feel like this can be more aggressive in enabling options as experimental
features. I'm ok if that's something we revisit after modern webkit is
building.

> Source/cmake/OptionsFTW.cmake:54
> +# Features in the same state on WinCairo and AppleWin

I still kinda feel like we should be targeting where we want things to be
rather than where things are currently.

> Source/cmake/OptionsFTW.cmake:213
> +find_package(CURL 7.60.0 REQUIRED)
>  find_package(ICU REQUIRED COMPONENTS data i18n uc)
> +find_package(JPEG 1.5.2 REQUIRED)
> +find_package(LibXml2 2.9.7 REQUIRED)
> +find_package(OpenSSL 2.0.0 REQUIRED)
> +find_package(PNG 1.6.34 REQUIRED)
> +find_package(Sqlite 3.23.1 REQUIRED)
> +find_package(ZLIB 1.2.11 REQUIRED)
> +find_package(LibPSL 0.20.2 REQUIRED)

Since one of the goals is to have roughly the same feature set as Apple Mac/iOS
ports do we want to add in OpenJPEG? I have it building but never integrated
it.

Not a blocker for landing. Just a question.