[webkit-reviews] review granted: [Bug 199349] Tapping on the bottom part of youtube video behaves as if controls were visible : [Attachment 373208] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 199349: Tapping on the bottom part of youtube video behaves as if controls
were visible
https://bugs.webkit.org/show_bug.cgi?id=199349

Attachment 373208: Patch

https://bugs.webkit.org/attachment.cgi?id=373208&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 373208
  --> https://bugs.webkit.org/attachment.cgi?id=373208
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373208&action=review

> Source/WebCore/ChangeLog:9
> +	   Synthetic click event should not be dispatched to a node that is
initially hidden and becomes visible by the touchStart event.

Quality "hidden" here as including opacity:0. Also say that we're deliberately
choose a different behavior from macOS.