[webkit-reviews] review granted: [Bug 194111] Web Inspector: Memory timeline starts from zero when both CPU and Memory timeline are enabled : [Attachment 360786] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 194111: Web Inspector: Memory timeline starts from zero when both CPU and
Memory timeline are enabled
https://bugs.webkit.org/show_bug.cgi?id=194111

Attachment 360786: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=360786&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 360786
  --> https://bugs.webkit.org/attachment.cgi?id=360786
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=360786&action=review

rs=me

> Source/WebCore/page/ResourceUsageThread.cpp:85
> +	   WTF::sleep(10_ms);

Where did the `10_ms` come from?  Is there any justification as to why that
value was chosen?

> Source/WebCore/page/ResourceUsageThread.cpp:127
> +    WTF::sleep(10_ms);

Should we also be waiting in the case that we already have observers?