[webkit-reviews] review granted: [Bug 194115] Web Inspector: Timeline Detail Views do not reset properly when new time range selection contains nothing : [Attachment 360791] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 194115: Web Inspector: Timeline Detail Views do not reset properly when new
time range selection contains nothing
https://bugs.webkit.org/show_bug.cgi?id=194115

Attachment 360791: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=360791&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 360791
  --> https://bugs.webkit.org/attachment.cgi?id=360791
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=360791&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:83
> +	   this.clear();

I think this deserves a ChangeLog comment.  Something like "Calling `.clear()`
will remove all UI from the selected range, but keep any non-range-specific
values (e.g. maximum usage) as they were in the UI.".