[webkit-reviews] review granted: [Bug 194070] Don't insert spaces at the beginning of a newline when using smart-copy-paste : [Attachment 360735] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 194070: Don't insert spaces at the beginning of a newline when using
smart-copy-paste
https://bugs.webkit.org/show_bug.cgi?id=194070

Attachment 360735: Patch

https://bugs.webkit.org/attachment.cgi?id=360735&action=review




--- Comment #14 from Tim Horton <thorton at apple.com> ---
Comment on attachment 360735
  --> https://bugs.webkit.org/attachment.cgi?id=360735
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360735&action=review

> Source/WebCore/ChangeLog:9
> +	   Also, if our inserted content beginning is at the end of a paragar,
do not instert a space.

PARAGAR
INSTERT

> LayoutTests/ChangeLog:7
> +	   Rebaseline a test the is dependant on a console log that changes
lines.

"the is"

>
LayoutTests/http/tests/security/anchor-download-block-crossorigin-expected.txt:
1
> -CONSOLE MESSAGE: line 88: The download attribute on anchor was ignored
because its href URL has a different security origin.
> +CONSOLE MESSAGE: line 107: The download attribute on anchor was ignored
because its href URL has a different security origin.

:|

> LayoutTests/resources/ui-helper.js:135
> +	       // only here to deal with async/sync copy/paste calls.
> +	       // once <rdar://problem/16207002> is resolved, should be able to
remove for faster tests.

Capitals, whole sentences, etc.