[webkit-reviews] review granted: [Bug 194113] Remove poisoning from CodeBlock and LLInt code. : [Attachment 360781] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 194113: Remove poisoning from CodeBlock and LLInt code.
https://bugs.webkit.org/show_bug.cgi?id=194113

Attachment 360781: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=360781&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 360781
  --> https://bugs.webkit.org/attachment.cgi?id=360781
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=360781&action=review

r=me with some suggestions.

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:535
> +    loadp CodeBlock::m_vm[scratch], scratch

scratch2 is no longer necessary.

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:-1037
> -    unpoison(_g_JSFunctionPoison, targetRegister, scratch)

scratch is no longer necessary.

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:-1049
> -    unpoison(_g_JSFunctionPoison, targetRegister, scratch)

Ditto.