[webkit-reviews] review granted: [Bug 193962] Dispatch pointercancel events when content is panned or zoomed on iOS : [Attachment 360774] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 193962: Dispatch pointercancel events when content is panned or zoomed on
iOS
https://bugs.webkit.org/show_bug.cgi?id=193962

Attachment 360774: Patch

https://bugs.webkit.org/attachment.cgi?id=360774&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 360774
  --> https://bugs.webkit.org/attachment.cgi?id=360774
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360774&action=review

> Source/WebCore/ChangeLog:11
> +	   has been cancelled, which is important because a cancelled pointer
should no longer dispatch any further pointer events, and
> +	   to cancel a pointer.

did you mean cancel the capture?

> Source/WebCore/dom/PointerEvent.h:59
> +    static Ref<PointerEvent> create(const AtomicString& type, int32_t
pointerId, String pointerType)

We really need PointerID to be a type somewhere.

> Source/WebCore/page/PointerCaptureController.h:59
> +	   String pointerType;

This should be an enum by this point. It probably should be an enum on
PointerEvent too.