[webkit-reviews] review granted: [Bug 194109] Web Inspector: Timeline time range selection should show duration alongside start and end : [Attachment 360778] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 194109: Web Inspector: Timeline time range selection should show duration
alongside start and end
https://bugs.webkit.org/show_bug.cgi?id=194109

Attachment 360778: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=360778&action=review




--- Comment #6 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 360778
  --> https://bugs.webkit.org/attachment.cgi?id=360778
[PATCH] Proposed Fix

rs=me

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:732
>	       let selectionStart = Number.secondsToString(startValue, true);

NIT: rather than pass `true`, we should use a `const` for all of them.

    const higherResolution = true;

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:734
> +	       const epsilon = 0.0001;

I get that we're using `0.0001` because it's a decimal point away from 1/1000,
but should we try using `Number.EPSILON` instead?