[webkit-reviews] review granted: [Bug 194108] Web Inspector: Timeline time range selection sometimes shows 0.000, should be just 0 : [Attachment 360775] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 31 14:12:03 PST 2019
Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 194108: Web Inspector: Timeline time range selection sometimes shows 0.000,
should be just 0
https://bugs.webkit.org/show_bug.cgi?id=194108
Attachment 360775: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=360775&action=review
--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 360775
--> https://bugs.webkit.org/attachment.cgi?id=360775
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=360775&action=review
rs=me
> Source/WebInspectorUI/UserInterface/Base/Utilities.js:1159
> const epsilon = 0.0001;
I get that we're using `0.0001` because it's a decimal point away from 1/1000,
but should we try using `Number.EPSILON` instead?
More information about the webkit-reviews
mailing list