[webkit-reviews] review granted: [Bug 191816] [css-scroll-snap] scroll-snap-align not honored on child with non-visible overflow : [Attachment 360715] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 191816: [css-scroll-snap] scroll-snap-align not honored on child with
non-visible overflow
https://bugs.webkit.org/show_bug.cgi?id=191816

Attachment 360715: Patch

https://bugs.webkit.org/attachment.cgi?id=360715&action=review




--- Comment #14 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 360715
  --> https://bugs.webkit.org/attachment.cgi?id=360715
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360715&action=review

> Source/WebCore/rendering/RenderLayerModelObject.cpp:222
> +	   const RenderBox* scrollSnapBox =
enclosingScrollableContainerForSnapping();

Nit - auto*?

> Source/WebCore/rendering/RenderObject.cpp:443
> +    auto* renderBox = &enclosingBox();

Nit - auto& renderBox = enclosingBox();, and use . instead of ->?

> Source/WebCore/rendering/RenderObject.cpp:447
> +	       return
renderBox->parentBox()->findEnclosingScrollableContainer();

Is it guaranteed that renderBox.parentBox() exists?