[webkit-reviews] review requested: [Bug 194086] [GLIB] WebDriver: race condition when session starts : [Attachment 360716] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has asked  for review:
Bug 194086: [GLIB] WebDriver: race condition when session starts
https://bugs.webkit.org/show_bug.cgi?id=194086

Attachment 360716: Patch

https://bugs.webkit.org/attachment.cgi?id=360716&action=review




--- Comment #2 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 360716
  --> https://bugs.webkit.org/attachment.cgi?id=360716
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360716&action=review

> Source/WebDriver/glib/SessionHostGlib.cpp:335
>	   m_connectionID = 0;
> -	   if (m_dbusConnection)
> +	   if (m_connectionID && m_dbusConnection)

So now this condition is always false because m_connectionID is set to 0 before
the if. Is this correct? Why not remove the if block then?