[webkit-reviews] review granted: [Bug 194080] Generalize ScrollingTreeScrollingNodeDelegate for use in macOS too, add a macOS subclass for frame/overflow scrolling : [Attachment 360693] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 194080: Generalize ScrollingTreeScrollingNodeDelegate for use in macOS too,
add a macOS subclass for frame/overflow scrolling
https://bugs.webkit.org/show_bug.cgi?id=194080

Attachment 360693: Patch

https://bugs.webkit.org/attachment.cgi?id=360693&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 360693
  --> https://bugs.webkit.org/attachment.cgi?id=360693
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360693&action=review

> Source/WebCore/ChangeLog:12
> +	   Add a macOS subclass, ScrollingTreeFrameScrollingNodeMac, which
takes over the basic scrolling, rubber-banding
> +	   and scroll snapping functionality from
ScrollingTreeFrameScrollingNodeMac. The delegate owns the ScrollController and

ScrollingTreeFrameScrollingNodeMac is probably not taking over from itself