[webkit-reviews] review granted: [Bug 194082] [JSC] Symbol should be in destructibleCellSpace : [Attachment 360694] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 194082: [JSC] Symbol should be in destructibleCellSpace
https://bugs.webkit.org/show_bug.cgi?id=194082

Attachment 360694: Patch

https://bugs.webkit.org/attachment.cgi?id=360694&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 360694
  --> https://bugs.webkit.org/attachment.cgi?id=360694
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360694&action=review

> Source/JavaScriptCore/runtime/Symbol.h:76
> +    PoisonedRef<SymbolPoison, SymbolImpl> m_symbolImpl;

Please revert the poisoning part of this change including the JIT portion. We
turned off poisoning. We should really strip it entirely from the code base.