[webkit-reviews] review granted: [Bug 153758] Web Inspector: Memory Timeline View should be responsive / resizable : [Attachment 360674] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 153758: Web Inspector: Memory Timeline View should be responsive /
resizable
https://bugs.webkit.org/show_bug.cgi?id=153758

Attachment 360674: Patch

https://bugs.webkit.org/attachment.cgi?id=360674&action=review




--- Comment #8 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 360674
  --> https://bugs.webkit.org/attachment.cgi?id=360674
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360674&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:165
> +	       function xScale(value) {

Why rename this from `time` to `value`?

> Source/WebInspectorUI/UserInterface/Views/LineChart.js:89
>      addPoint(x, y)
>      {
>	   this._points.push({x, y});
> +
> +	   this.needsLayout();
>      }
>  
>      clear()
>      {
>	   this._points = [];
> +
> +	   this.needsLayout();
>      }

I don't like these changes. This is going to mean lots and lots of unnecessary
needsLayout calls happening when adding say 1000 points to a chart (which will
be the common case).