[webkit-reviews] review granted: [Bug 191802] [WebAssembly] Change BBQ to generate Air IR : [Attachment 360655] patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 191802: [WebAssembly] Change BBQ to generate Air IR
https://bugs.webkit.org/show_bug.cgi?id=191802

Attachment 360655: patch

https://bugs.webkit.org/attachment.cgi?id=360655&action=review




--- Comment #45 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 360655
  --> https://bugs.webkit.org/attachment.cgi?id=360655
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360655&action=review

r=me.

> Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:305
> +	   // FIXME: Fins a way to use origin here.

typo: Fins => Find

> Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:1290
> +    auto storeArg = [&] () {
> +	   if (Arg::isValidAddrForm(offset,
B3::widthForBytes(sizeOfStoreOp(op))))
> +	       return Arg::addr(pointer, offset);
> +	   immTmp = g64();
> +	   newPtr = g64();
> +	   append(Move, Arg::bigImm(offset), immTmp);
> +	   append(Add64, immTmp, pointer, newPtr);
> +	   return Arg::addr(newPtr);
> +    };

Why not just make an Arg::Addr and pass that in below rather than have a lambda
that you call every time?

> Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:2463
> +	   // the numbers are would be positive anyway as a signed integer.
Since we cannot materialize constants into fprs we have b3 do it

I think you mean air :P

> Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:2541
> +	   // the numbers would be positive anyway as a signed integer. Since
we cannot materialize constants into fprs we have b3 do it

ditto.