[webkit-reviews] review granted: [Bug 194059] [NSDragItem init] is unavailable : [Attachment 360639] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Keith Rollin
<krollin at apple.com>'s request for review:
Bug 194059: [NSDragItem init] is unavailable
https://bugs.webkit.org/show_bug.cgi?id=194059

Attachment 360639: Patch

https://bugs.webkit.org/attachment.cgi?id=360639&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 360639
  --> https://bugs.webkit.org/attachment.cgi?id=360639
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360639&action=review

> Tools/DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:280
> +	   auto item = adoptNS([[NSDraggingItem alloc]
initWithPasteboardWriter:(id<NSPasteboardWriting>)receiver.get()]);

Nit - we generally prefer spaces between id and < for ObjC protocols like this.

> Tools/TestWebKitAPI/mac/TestDraggingInfo.mm:118
> +	   auto item = adoptNS([[NSDraggingItem alloc]
initWithPasteboardWriter:(id<NSPasteboardWriting>)receiver.get()]);

It might be worth adding a FIXME here referencing
https://bugs.webkit.org/show_bug.cgi?id=194060, too.