[webkit-reviews] review granted: [Bug 194048] [WebGPU] Support GPUDepthStencilStateDescriptor : [Attachment 360626] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 194048: [WebGPU] Support GPUDepthStencilStateDescriptor
https://bugs.webkit.org/show_bug.cgi?id=194048

Attachment 360626: Patch

https://bugs.webkit.org/attachment.cgi?id=360626&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 360626
  --> https://bugs.webkit.org/attachment.cgi?id=360626
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360626&action=review

> Source/WebCore/Modules/webgpu/WebGPUCompareFunction.h:34
> +using WebGPUCompareFunction = GPUCompareFunction;

I wonder if we even need the ImplementedAs in this case, since we're actually
using exactly the same thing.

> Source/WebCore/Modules/webgpu/WebGPUDepthStencilStateDescriptor.h:34
> +using WebGPUDepthStencilStateDescriptor = GPUDepthStencilStateDescriptor;

Same here.