[webkit-reviews] review granted: [Bug 194003] <rdar://problem/47570443> Responsiveness timers are too expensive for frequent events : [Attachment 360549] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 194003: <rdar://problem/47570443> Responsiveness timers are too expensive
for frequent events
https://bugs.webkit.org/show_bug.cgi?id=194003

Attachment 360549: Patch

https://bugs.webkit.org/attachment.cgi?id=360549&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 360549
  --> https://bugs.webkit.org/attachment.cgi?id=360549
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360549&action=review

r=me

> Source/WebKit/ChangeLog:22
> +	   The second improvement of the patch is to avoid that by not killing
the timer
> +	   when we hear back from the WebProcess.

I wonder if we should just make this the default behavior of WebCore::Timer or
ResponsivenessTimer.

> Source/WebKit/ChangeLog:30
> +	   In the case of wheel events, this is find since we saved a bunch of
CPU already.

fine