[webkit-reviews] review granted: [Bug 194037] Remove assertion that CachedSymbolTables should have no RareData : [Attachment 360612] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 30 14:06:39 PST 2019
Mark Lam <mark.lam at apple.com> has granted Tadeu Zagallo <tzagallo at apple.com>'s
request for review:
Bug 194037: Remove assertion that CachedSymbolTables should have no RareData
https://bugs.webkit.org/show_bug.cgi?id=194037
Attachment 360612: Patch
https://bugs.webkit.org/attachment.cgi?id=360612&action=review
--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 360612
--> https://bugs.webkit.org/attachment.cgi?id=360612
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=360612&action=review
r=me
> Source/JavaScriptCore/ChangeLog:9
> + It turns out that we don't need to cache the SymbolTableRareData,
but
> + we should not assert that it's empty.
nit: Do you mean 'and we should not assert ..."?
More information about the webkit-reviews
mailing list