[webkit-reviews] review granted: [Bug 193747] Refactor ServiceWorkerJob management by ServiceWorkerContainer to make it more memory safe : [Attachment 360360] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 193747: Refactor ServiceWorkerJob management by ServiceWorkerContainer to
make it more memory safe
https://bugs.webkit.org/show_bug.cgi?id=193747

Attachment 360360: Patch

https://bugs.webkit.org/attachment.cgi?id=360360&action=review




--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 360360
  --> https://bugs.webkit.org/attachment.cgi?id=360360
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360360&action=review

r=me with comments

> Source/WebCore/ChangeLog:14
> +	   Before the patch, the jobs map was never cleared, which is creating
a ref cycle whenever a job is not succesfull.

typo: succesfull

> Source/WebCore/ChangeLog:16
> +	   Before the patch, unsetPendingActivity was only called for
successful jobs finishing.

"successful", there it is.

> Source/WebCore/workers/service/ServiceWorkerContainer.h:125
> +	   RefPtr<PendingActivity<ServiceWorkerContainer>> pendingActivity;

Can this be a Ref<> ?

> Source/WebCore/workers/service/ServiceWorkerJob.h:50
> +class ServiceWorkerJob : public WorkerScriptLoaderClient {

WTF_MAKE_FAST_ALLOCATED; since you're dropping RefCounted.