[webkit-reviews] review granted: [Bug 193816] [Curl] Fix DRT crash related to private browsing. : [Attachment 360574] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 30 09:57:21 PST 2019

Michael Catanzaro <mcatanzaro at igalia.com> has granted Takashi Komori
<Takashi.Komori at sony.com>'s request for review:
Bug 193816: [Curl] Fix DRT crash related to private browsing.

Attachment 360574: Patch


--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 360574
  --> https://bugs.webkit.org/attachment.cgi?id=360574

View in context: https://bugs.webkit.org/attachment.cgi?id=360574&action=review

> Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp:115
> +    addResult.iterator->value =
std::make_unique<WebCore::NetworkStorageSession>(sessionID, nullptr);

Unrelated: I think you should remove the second parameter from your
NetworkStorageSession constructor. It's a curl-specific constructor, and I
believe you have to always pass nullptr for it to not crash. :)

More information about the webkit-reviews mailing list