[webkit-reviews] review granted: [Bug 194002] Add some basic geometry information to the scrolling tree : [Attachment 360552] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 194002: Add some basic geometry information to the scrolling tree
https://bugs.webkit.org/show_bug.cgi?id=194002

Attachment 360552: Patch

https://bugs.webkit.org/attachment.cgi?id=360552&action=review




--- Comment #6 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 360552
  --> https://bugs.webkit.org/attachment.cgi?id=360552
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360552&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:3928
> +    if (m_renderView.frame().isMainFrame())
> +	   scrollingGeometry.parentRelativeScrollableRect =
frameView.frameRect();
> +    else
> +	   scrollingGeometry.parentRelativeScrollableRect = LayoutRect({ },
LayoutSize(frameView.size()));

Why are these cases different?

> Source/WebCore/rendering/RenderLayerCompositor.cpp:3980
> +    if (const Vector<LayoutUnit>* offsets = layer.horizontalSnapOffsets())
> +	   scrollingGeometry.horizontalSnapOffsets = *offsets;
> +    if (const Vector<LayoutUnit>* offsets = layer.verticalSnapOffsets())
> +	   scrollingGeometry.verticalSnapOffsets = *offsets;
> +    if (const Vector<ScrollOffsetRange<LayoutUnit>>* ranges =
layer.horizontalSnapOffsetRanges())
> +	   scrollingGeometry.horizontalSnapOffsetRanges = *ranges;
> +    if (const Vector<ScrollOffsetRange<LayoutUnit>>* ranges =
layer.verticalSnapOffsetRanges())
> +	   scrollingGeometry.verticalSnapOffsetRanges = *ranges;

auto*