[webkit-reviews] review granted: [Bug 193996] iOS: Nullptr crash in WebPage::getPositionInformation dereferencing an input element for data list : [Attachment 360524] Fixes the bug

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 193996: iOS: Nullptr crash in WebPage::getPositionInformation dereferencing
an input element for data list
https://bugs.webkit.org/show_bug.cgi?id=193996

Attachment 360524: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=360524&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 360524
  --> https://bugs.webkit.org/attachment.cgi?id=360524
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=360524&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2251
> +    if (hitNode && is<HTMLInputElement>(*hitNode)) {

Let's just check is<HTMLInputElement>(hitNode).