[webkit-reviews] review denied: [Bug 193878] AX: VoiceOver allows to interact with a disabled <select> element : [Attachment 360439] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Eric Liang
<ericliang at apple.com>'s request for review:
Bug 193878: AX: VoiceOver allows to interact with a disabled <select> element
https://bugs.webkit.org/show_bug.cgi?id=193878

Attachment 360439: Patch

https://bugs.webkit.org/attachment.cgi?id=360439&action=review




--- Comment #26 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 360439
  --> https://bugs.webkit.org/attachment.cgi?id=360439
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360439&action=review

> Source/WebCore/accessibility/AccessibilityMenuList.cpp:51
> +	   RenderMenuList* menuList = static_cast<RenderMenuList*>(renderer());

Don't use static_cast<>. We have casting macros, like is<> and downcast<> which
assert that the cast is correct.