[webkit-reviews] review granted: [Bug 193968] [ews-build] Configure buildbot to send events to ews-app : [Attachment 360477] Proposed patch

[bugzilla-daemon at webkit.org]

Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 193968: [ews-build] Configure buildbot to send events to ews-app
https://bugs.webkit.org/show_bug.cgi?id=193968

Attachment 360477: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=360477&action=review




--- Comment #3 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 360477
  --> https://bugs.webkit.org/attachment.cgi?id=360477
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360477&action=review

lgtm with a couple comments.

> Tools/BuildSlaveSupport/ews-build/events.py:37
> +

I forget our sorting policy when using 'from', but TextMate sorts these:
from buildbot.util import service
from twisted.internet import defer
from twisted.internet import reactor
from twisted.internet.defer import succeed
from twisted.python import log
from twisted.web.client import Agent
from twisted.web.http_headers import Headers
from twisted.web.iweb import IBodyProducer
from zope.interface import implements

> Tools/BuildSlaveSupport/ews-build/events.py:77
> +    def __init__(self, type_prefix="", name='Events'):

mixing "" and '' here.

> Tools/BuildSlaveSupport/ews-build/events.py:102
> +    def getPatchid(self, build):

maybe consider getPatch_id ?
disregard if we are trying to stay consistent with other uses.