[webkit-reviews] review granted: [Bug 182325] Align with Fetch on data: URLs : [Attachment 360370] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 29 12:22:36 PST 2019
Alex Christensen <achristensen at apple.com> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 182325: Align with Fetch on data: URLs
https://bugs.webkit.org/show_bug.cgi?id=182325
Attachment 360370: Patch
https://bugs.webkit.org/attachment.cgi?id=360370&action=review
--- Comment #45 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 360370
--> https://bugs.webkit.org/attachment.cgi?id=360370
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=360370&action=review
r=me
> Source/WebCore/platform/network/ParsedContentType.cpp:188
> + if (m_contentType.contains('\r') || m_contentType.contains('\n'))
These two checks could be done in one pass. Use this function in WTFString.h:
size_t find(CodeUnitMatchFunction matchFunction, unsigned start = 0)
> Source/WebCore/platform/network/ParsedContentType.cpp:289
> + return parsedContentType;
I think this might unnecessarily copy parsedContentType and
WTFMove(parsedContentType) might not, but I could be wrong. Please double
check.
More information about the webkit-reviews
mailing list