[webkit-reviews] review granted: [Bug 193924] StorageAccess API calls should be direct to the Network Process : [Attachment 360471] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 193924: StorageAccess API calls should be direct to the Network Process
https://bugs.webkit.org/show_bug.cgi?id=193924

Attachment 360471: Patch

https://bugs.webkit.org/attachment.cgi?id=360471&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 360471
  --> https://bugs.webkit.org/attachment.cgi?id=360471
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360471&action=review

r=me with one minor change.

> Source/WebKit/UIProcess/WebPageProxy.h:1383
> +    static void requestStorageAccessConfirm(uint64_t pageID, uint64_t
frameID, const String& subFrameHost, const String& topFrameHost,
CompletionHandler<void(bool)>&&);

This should not be static.  The NetworkProcessProxy should find the correct
WebPageProxy and call a member function on it.