[webkit-reviews] review granted: [Bug 132333] Remove unneeded CPU(BIG_ENDIAN) handling in LLInt after new bytecode format. : [Attachment 360475] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 132333: Remove unneeded CPU(BIG_ENDIAN) handling in LLInt after new
bytecode format.
https://bugs.webkit.org/show_bug.cgi?id=132333

Attachment 360475: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=360475&action=review




--- Comment #67 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 360475
  --> https://bugs.webkit.org/attachment.cgi?id=360475
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=360475&action=review

r=me with suggestion.

> Source/JavaScriptCore/bytecode/InstructionStream.h:-230
> -#endif // !CPU(BIG_ENDIAN)

Should we use the above conversion by bitwise_cast, since non-active union
field access is UB.
Like the following. (I'm not sure the following can be compiled well).
auto bytes = bitwise_cast<uint8_t[4]>(i);