[webkit-reviews] review granted: [Bug 193357] Adopt new VCP SPI : [Attachment 360435] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 193357: Adopt new VCP SPI
https://bugs.webkit.org/show_bug.cgi?id=193357

Attachment 360435: Patch

https://bugs.webkit.org/attachment.cgi?id=360435&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 360435
  --> https://bugs.webkit.org/attachment.cgi?id=360435
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360435&action=review

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVi
deoEncoderH264.mm:45
> +void testCompressionOutputCallback(void *, void *, OSStatus,
VTEncodeInfoFlags, CMSampleBufferRef)

Nit: sanity checking the buffer and status parameters would make this even
safer.

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVi
deoEncoderH264.mm:73
> +	   if (pixelFormat) {

Shouldn’t these tests be done before you use the values to create the
dictionary?