[webkit-reviews] review granted: [Bug 193907] REGRESSION(r240553): [iOS] Crash in ScrollingTree::updateTreeFromStateNode when attempting to log in to icloud.com : [Attachment 360431] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 193907: REGRESSION(r240553): [iOS] Crash in
ScrollingTree::updateTreeFromStateNode when attempting to log in to icloud.com
https://bugs.webkit.org/show_bug.cgi?id=193907

Attachment 360431: Patch

https://bugs.webkit.org/attachment.cgi?id=360431&action=review




--- Comment #6 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 360431
  --> https://bugs.webkit.org/attachment.cgi?id=360431
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360431&action=review

> Source/WebCore/ChangeLog:26
> +

It looks like these two refactoring tasks are independent from this bug and
could have been handled in separate patches, but ok.

> Source/WebCore/ChangeLog:27
> +	   Tested by existing tests.

Shouldn't we add a crash test?