[webkit-reviews] review granted: [Bug 193933] Use lambdas instead of member pointer functions for TransactionOperationImpl : [Attachment 360396] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 28 17:58:48 PST 2019


Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 193933: Use lambdas instead of member pointer functions for
TransactionOperationImpl
https://bugs.webkit.org/show_bug.cgi?id=193933

Attachment 360396: Patch

https://bugs.webkit.org/attachment.cgi?id=360396&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 360396
  --> https://bugs.webkit.org/attachment.cgi?id=360396
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360396&action=review

> Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:-1299
> -    scheduleOperation(IDBClient::createTransactionOperation(*this,
&IDBTransaction::didDeleteIndexOnServer, &IDBTransaction::deleteIndexOnServer,
objectStoreIdentifier, indexName));

Seems so weird in all of these that the "did" comes after the "do"


More information about the webkit-reviews mailing list