[webkit-reviews] review granted: [Bug 193882] Make it easier for non-Apple ports to enable dark mode CSS support : [Attachment 360305] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 28 17:12:28 PST 2019
Megan Gardner <megan_gardner at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 193882: Make it easier for non-Apple ports to enable dark mode CSS support
https://bugs.webkit.org/show_bug.cgi?id=193882
Attachment 360305: Patch
https://bugs.webkit.org/attachment.cgi?id=360305&action=review
--- Comment #6 from Megan Gardner <megan_gardner at apple.com> ---
Comment on attachment 360305
--> https://bugs.webkit.org/attachment.cgi?id=360305
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=360305&action=review
> Source/WebKit/WebProcess/WebPage/WebPage.cpp:4507
> +
nit - extra line
> Source/WebKitLegacy/mac/WebView/WebView.mm:5308
>
I feel a little weird about this not have a default
implementation/implementation on other platforms, but since it's wholly in the
scope, I won't whine too loudly.
More information about the webkit-reviews
mailing list