[webkit-reviews] review requested: [Bug 193622] [GTK][WPE] Add content extensions support in WKTR and unskip layout tests : [Attachment 360393] Patch v7
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 28 16:00:27 PST 2019
Adrian Perez <aperez at igalia.com> has asked for review:
Bug 193622: [GTK][WPE] Add content extensions support in WKTR and unskip layout
tests
https://bugs.webkit.org/show_bug.cgi?id=193622
Attachment 360393: Patch v7
https://bugs.webkit.org/attachment.cgi?id=360393&action=review
--- Comment #23 from Adrian Perez <aperez at igalia.com> ---
Created attachment 360393
--> https://bugs.webkit.org/attachment.cgi?id=360393&action=review
Patch v7
The Cocoa port uses a global WKWebViewConfiguration. Add an accesor
TestController::userContentController() which picks the user content
controller from the global for the Cocoa port, and from the current
page configuration for the other ports.
This also addresses the rest of review comments by Carlos García and
Loïc Yhuel (thanks!)
More information about the webkit-reviews
mailing list