[webkit-reviews] review granted: [Bug 193456] [iOS] Attempting to open a Keynote document to iCloud.com from iCloud Files causes crash : [Attachment 360210] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 193456: [iOS] Attempting to open a Keynote document to iCloud.com from
iCloud Files causes crash
https://bugs.webkit.org/show_bug.cgi?id=193456

Attachment 360210: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=360210&action=review




--- Comment #12 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 360210
  --> https://bugs.webkit.org/attachment.cgi?id=360210
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=360210&action=review

>>>>
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:175
>>>> +	  (global-name "com.apple.iconservices"))
>>> 
>>> I think the prior line might be a typo: "com.apple.iconservice" ->
"com.apple.iconservice".
>>> 
>>> Can you try just adding the 's' to icon service and see if it fixes it?
>> 
>> This does not solve the issue.
>> 
>> Note that even though there is:
>> 
>>     (xpc-service-name "com.apple.lsdiconservice")
>> 
>> There is also (further down):
>> 
>>     (global-name "com.apple.lsdiconservice")
>> 
>> ---
>> 
>> Would you rather I move the addition:
>> 
>>     (allow mach-lookup
>>	   (global-name "com.apple.iconservices"))
>> 
>> Down into the section at the bottom which has "with report":
>> 
>>     (allow mach-lookup (with report)
>>	   ...)
> 
> Okay. Thank you for checking.

Can you please change the incorrect string:
    (xpc-service-name "com.apple.iconservice")

To the correct service name:
    (xpc-service-name "com.apple.iconservices")

... and then add your new rule for global-name?

(allow mach-lookup
    (global-name "com.apple.iconservices"))