[webkit-reviews] review granted: [Bug 193801] [JSC] RegExpConstructor should not have own IsoSubspace : [Attachment 360301] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 28 11:47:20 PST 2019
Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 193801: [JSC] RegExpConstructor should not have own IsoSubspace
https://bugs.webkit.org/show_bug.cgi?id=193801
Attachment 360301: Patch
https://bugs.webkit.org/attachment.cgi?id=360301&action=review
--- Comment #10 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 360301
--> https://bugs.webkit.org/attachment.cgi?id=360301
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=360301&action=review
r=me
> Source/JavaScriptCore/runtime/RegExpGlobalDataInlines.h:61
> +ALWAYS_INLINE MatchResult RegExpGlobalData::performMatch(VM& vm,
JSGlobalObject* owner, RegExp* regExp, JSString* string, const String& input,
int startOffset)
nit: insert blank line before this.
More information about the webkit-reviews
mailing list