[webkit-reviews] review granted: [Bug 193887] [ews-build] Add build step to print bot Configuration : [Attachment 360306] Proposed patch

[bugzilla-daemon at webkit.org]

Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 193887: [ews-build] Add build step to print bot Configuration
https://bugs.webkit.org/show_bug.cgi?id=193887

Attachment 360306: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=360306&action=review




--- Comment #3 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 360306
  --> https://bugs.webkit.org/attachment.cgi?id=360306
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360306&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:759
> +

These commands will not work for any Windows EWS bots. We should probably do a
platform check, or at least put in a #FIXME to indicate any non Mac/unix work
needed.
(since halt/flunk/warn on failure is False, this won't break anything on those
platforms...but it would be nice to do the right thing pending OS.