[webkit-reviews] review denied: [Bug 193913] [macOS] Crash when control-clicking or copying text rendered with a web font : [Attachment 360349] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 28 10:21:15 PST 2019
mitz at webkit.org has denied Per Arne Vollan <pvollan at apple.com>'s request for
review:
Bug 193913: [macOS] Crash when control-clicking or copying text rendered with a
web font
https://bugs.webkit.org/show_bug.cgi?id=193913
Attachment 360349: Patch
https://bugs.webkit.org/attachment.cgi?id=360349&action=review
--- Comment #3 from mitz at webkit.org ---
Comment on attachment 360349
--> https://bugs.webkit.org/attachment.cgi?id=360349
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=360349&action=review
> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:575
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 101300
Comparisons against VERSION_MIN_REQUIRED and VERSION_MAX_ALLOWED should always
use either >= or <, never <= or >.
More information about the webkit-reviews
mailing list