[webkit-reviews] review requested: [Bug 193735] [ews-app] Add method to save Build data to database : [Attachment 360334] Updated patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has asked  for review:
Bug 193735: [ews-app] Add method to save Build data to database
https://bugs.webkit.org/show_bug.cgi?id=193735

Attachment 360334: Updated patch

https://bugs.webkit.org/attachment.cgi?id=360334&action=review




--- Comment #3 from Aakash Jain <aakash_jain at apple.com> ---
Created attachment 360334

  --> https://bugs.webkit.org/attachment.cgi?id=360334&action=review

Updated patch

> would this be ok as 'is_valid_id' ?
renamed. Also updated the method to make it more generic.

> since we are using underscores for patch_id, should we continue that with
build_id, builder_id?
Uploaded Patch for this change in
https://bugs.webkit.org/show_bug.cgi?id=193883 Also updated this patch to use
build_id, builder_id.

> nit: extra space before the last 'and'
Fixed.

Also added some more functionality (e.g.: update_build() method). Can you
please review again?