[webkit-reviews] review granted: [Bug 193773] [css-logical] inset shorthand should not accept unitless length quirk : [Attachment 360021] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Oriol Brufau
<obrufau at igalia.com>'s request for review:
Bug 193773: [css-logical] inset shorthand should not accept unitless length
quirk
https://bugs.webkit.org/show_bug.cgi?id=193773

Attachment 360021: Patch

https://bugs.webkit.org/attachment.cgi?id=360021&action=review




--- Comment #2 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 360021
  --> https://bugs.webkit.org/attachment.cgi?id=360021
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360021&action=review

LGTM, maybe we need one more test check the comments inline.

> Source/WebCore/ChangeLog:10
> +	   should reject it.

Could you link the CSSWG discussion or the spec here? Thanks.

> LayoutTests/imported/w3c/ChangeLog:9
> +	   allowed in the 'inset' shorthand.

Is there any test checking that unitless lenghts are still allowed on quirks
mode?