[webkit-reviews] review granted: [Bug 193884] REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h : [Attachment 360300] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 27 15:27:07 PST 2019


Jiewen Tan <jiewen_tan at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 193884: REGRESSION (r236481): Move soft-linking of
LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
https://bugs.webkit.org/show_bug.cgi?id=193884

Attachment 360300: Patch v1

https://bugs.webkit.org/attachment.cgi?id=360300&action=review




--- Comment #2 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 360300
  --> https://bugs.webkit.org/attachment.cgi?id=360300
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=360300&action=review

Thanks Dave for making the correction. LGTM. r=me.

> Source/WebKit/SourcesCocoa.txt:473
> +UIProcess/WebAuthentication/Cocoa/LocalAuthenticationSoftLink.mm @no-unify

Do we really need this?


More information about the webkit-reviews mailing list