[webkit-reviews] review granted: [Bug 193881] Use a load optimizer for some sites : [Attachment 360281] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 27 11:04:55 PST 2019


Brent Fulgham <bfulgham at webkit.org> has granted  review:
Bug 193881: Use a load optimizer for some sites
https://bugs.webkit.org/show_bug.cgi?id=193881

Attachment 360281: Patch

https://bugs.webkit.org/attachment.cgi?id=360281&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 360281
  --> https://bugs.webkit.org/attachment.cgi?id=360281
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360281&action=review

R=me after fixing the ChangeLog and style warning.

> Source/WebKitLegacy/ChangeLog:9
> +	   * WebKitLegacy.xcodeproj/project.pbxproj:

I don’t think this changelog is right. He load optimizer isn’t relevant to
WebKitLegacy.

Did you mean to make this Changelog for the WebKit directory?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm:29
> +#import <WebKitAdditions/TestLoadOptimizerAdditions.mm>

Not much of a test! :-)

I assume we’ll add some over the coming weeks.


More information about the webkit-reviews mailing list