[webkit-reviews] review granted: [Bug 193786] Turn on Smart Paste : [Attachment 360201] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 193786: Turn on Smart Paste
https://bugs.webkit.org/show_bug.cgi?id=193786

Attachment 360201: Patch

https://bugs.webkit.org/attachment.cgi?id=360201&action=review




--- Comment #15 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 360201
  --> https://bugs.webkit.org/attachment.cgi?id=360201
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360201&action=review

r=me, provided EWS is happy. It looks like either macOS needs rebaselined
expectations, or the tests need to be tweaked in such a way that they fulfill
existing expectations.

> Source/WebCore/ChangeLog:8
> +	   Turned on a modified tests:

Perhaps something like, "Enabled and modified existing tests:"?

> LayoutTests/editing/pasteboard/smart-paste-008.html:16
> +    await
UIHelper.selectWordByDoubleTapOrClick(document.getElementById('test'));

Nit - UIHelper.selectWordByDoubleTapOrClick(e);

> LayoutTests/platform/ios/TestExpectations:2140
> +

Nit - stray newline.