[webkit-reviews] review granted: [Bug 193831] REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL : [Attachment 360191] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 193831: REGRESSION: Some USDz from 3rd party websites don't go directly to
AR QL
https://bugs.webkit.org/show_bug.cgi?id=193831

Attachment 360191: Patch

https://bugs.webkit.org/attachment.cgi?id=360191&action=review




--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 360191
  --> https://bugs.webkit.org/attachment.cgi?id=360191
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360191&action=review

r=me with comments

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:560
> +TEST(ProcessSwap, NoSwappingForTLDPlus2)

No! this is not a Typo, I really meant eTLD+1.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:1632
> +    TestWebKitAPI::Util::sleep(1);

How about 0.5? 1 seems long.

Also, can you set didStartProvisionalLoad to false before clicking the link and
make sure it is still false here?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:1667
> +    TestWebKitAPI::Util::sleep(1);

same comments as above.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:3014
> +TEST(ProcessSwap, ProcessReUseTLDPlus2)

Not a typo.